Skip to content

[AIRFLOW-5625] Update MLEngine integration doc and typehint#6293

Merged
potiuk merged 2 commits intoapache:masterfrom
PolideaInternal:AIRFLOW-5625
Oct 13, 2019
Merged

[AIRFLOW-5625] Update MLEngine integration doc and typehint#6293
potiuk merged 2 commits intoapache:masterfrom
PolideaInternal:AIRFLOW-5625

Conversation

@mik-laj
Copy link
Copy Markdown
Member

@mik-laj mik-laj commented Oct 9, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5625
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Oct 9, 2019
@mik-laj mik-laj changed the title [AIRFLOW-5625][depends on AIRFLOW-5624,AIRFLOW-5617] Update MLEngine integration doc and typehint [AIRFLOW-5625][depends on AIRFLOW-5624] Update MLEngine integration doc and typehint Oct 11, 2019
@mik-laj mik-laj changed the title [AIRFLOW-5625][depends on AIRFLOW-5624] Update MLEngine integration doc and typehint [AIRFLOW-5625] Update MLEngine integration doc and typehint Oct 13, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 13, 2019

Codecov Report

Merging #6293 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6293      +/-   ##
==========================================
+ Coverage   80.34%   80.35%   +<.01%     
==========================================
  Files         616      616              
  Lines       35733    35735       +2     
==========================================
+ Hits        28711    28716       +5     
+ Misses       7022     7019       -3
Impacted Files Coverage Δ
airflow/gcp/hooks/cloud_build.py 100% <ø> (ø) ⬆️
airflow/gcp/operators/mlengine.py 89.51% <ø> (ø) ⬆️
airflow/gcp/hooks/mlengine.py 82.91% <100%> (+0.21%) ⬆️
airflow/models/taskinstance.py 93.77% <0%> (+0.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0d98a7...15b52b5. Read the comment docs.

@potiuk potiuk merged commit 9c74ecb into apache:master Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants